Tests: Make tests not trigger Migrate 4.0.0-beta.1 warnings #2364
Conversation
Changes: * Checkboxradio: Change `.attr( "checked", true )` to `.attr( "checked", "checked" ) * Selectmenu: Disable the `boolean-attributes` patch for one assertion where it's impossible to avoid
|
@fnagel PTAL |
|
@fnagel BTW, if you generally approve a PR but just want a simple typo to be fixed in an obvious way then I'd prefer if you approve with a comment. I am not merging PRs blindly, I read comments first, so I'd fix the text, but then I'd be able to merge immediately, without waiting for another review. |
mgol
dismissed
fnagel’s stale review
I'll dismiss your review, @fnagel, since from your comment it seemed you only had this single remark which I fixed, Timmy approved the PR and almost a week have passed.
Sure, I will do next time. |
Changes: * Checkboxradio: Change `.attr( "checked", true )` to `.attr( "checked", "checked" ) * Selectmenu: Disable the `boolean-attributes` patch for one assertion where it's impossible to avoid Closes jquerygh-2364
Changes:
.attr( "checked", true )to `.attr( "checked", "checked" )boolean-attributespatch for one assertion where it's impossible to avoid